[PATCH] Avoid one 'cast increases required alignment' warning

[doughera]

The attached patch eliminates one 'cast increases required alignment of target type' warning in src/packfile/pf_items.c. It also replaces a hard-wired assumption that sizeof(opcode_t) == 4 with an explicit sizeof(opcode_t), and simplifies the padding code.

[jkeenan]

Applied this patch and Andy D's other patch in r37288. Confirmed that this quieted one previously existing make warning re src/packfile/pf_items.c on Darwin/PPC.

Will close ticket within two days unless someone objects. Thank you very much.

kid51

[doughera]

Thanks for applying it. I've attached a minor whitespace-only follow-up patch to satisfy the t/codingstd/c_paren.t test. (Old habits are hard to break.)

[jkeenan]

Replying to doughera:

Thanks for applying it. I've attached a minor whitespace-only follow-up patch to satisfy the t/codingstd/c_paren.t test. (Old habits are hard to break.)

I'll look at this tonight after work, unless someone beats me to it.

[coke]

'make codetest' now passes again in r37310. Thanks.