Ticket #430 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] Avoid one 'cast increases required alignment' warning

Reported by: doughera Owned by: jkeenan
Priority: minor Milestone:
Component: none Version: trunk
Severity: low Keywords: packfile
Cc: Language:
Patch status: applied Platform:

Description

The attached patch eliminates one 'cast increases required alignment of target type' warning in src/packfile/pf_items.c. It also replaces a hard-wired assumption that sizeof(opcode_t) == 4 with an explicit sizeof(opcode_t), and simplifies the padding code.

Attachments

pf_items.p1 Download (0.9 KB) - added by doughera 5 years ago.
pf_items.p3 Download (0.9 KB) - added by doughera 5 years ago.

Change History

Changed 5 years ago by doughera

  Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

  Changed 5 years ago by jkeenan

  • keywords packfile added
  • priority changed from normal to minor
  • version set to trunk
  • severity changed from medium to low
  • patch set to applied

Applied this patch and Andy D's other patch in r37288. Confirmed that this quieted one previously existing make warning re src/packfile/pf_items.c on Darwin/PPC.

Will close ticket within two days unless someone objects. Thank you very much.

kid51

follow-up: ↓ 4   Changed 5 years ago by doughera

Thanks for applying it. I've attached a minor whitespace-only follow-up patch to satisfy the t/codingstd/c_paren.t test. (Old habits are hard to break.)

Changed 5 years ago by doughera

in reply to: ↑ 3   Changed 5 years ago by jkeenan

Replying to doughera:

Thanks for applying it. I've attached a minor whitespace-only follow-up patch to satisfy the t/codingstd/c_paren.t test. (Old habits are hard to break.)

I'll look at this tonight after work, unless someone beats me to it.

  Changed 5 years ago by coke

'make codetest' now passes again in r37310. Thanks.

  Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.