Ticket #436 (closed RFC: done)

Opened 5 years ago

Last modified 5 years ago

pbc format and pdd13_bytecde

Reported by: NotFound Owned by:
Priority: major Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

As discussed in #parrotsketch, pdd13 must document the current pbc format, if it differs from the proposed.

The current problens I've seen are:

The segment header fields itype, id and sized, documented in src/packfile.c in the PackFile_new function, are not mentioned in the pdd. Is not clear if they are intended for depercation or just undocumented yet. The size field is used in several segment types.

The use of the size field is inconsistent. The pir debug segment uses it for the size of his first table, but the annotations segment has his own internal field for each of his tables. Is not clear to me if we must change this to a more coherent usage, or just document current practice for 1.0 and think about changes later.

examples/tools/pbc_checker.cpp shows in a way independent of parrot sources and library how the current practice works, it can read read generated in any platform (at least in those I've been able to test).

Attachments

pdd13fixes-1.patch Download (7.3 KB) - added by NotFound 5 years ago.
First attempt at pdd13 fix
pdd13fixes-2.patch Download (7.3 KB) - added by NotFound 5 years ago.
Fixed a confusion in the directory format segment

Change History

Changed 5 years ago by NotFound

First attempt at pdd13 fix

Changed 5 years ago by NotFound

Added a patch with the first attempt to reflect current practice in pdd13

Changed 5 years ago by NotFound

Fixed a confusion in the directory format segment

Changed 5 years ago by NotFound

Second patch, fixing a confusion in the previous with the directory type segment found when updating pbc_checker.

Changed 5 years ago by NotFound

  • status changed from new to closed
  • resolution set to done

Done in r37524, with the addition of a note about the unimplemented state of the Encoding field in string constants.

Note: See TracTickets for help on using tickets.