Ticket #447 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

[CAGE] src/hash.c cleanup: fix functions taking a Hash** arg

Reported by: cotto Owned by:
Priority: normal Milestone: 1.1
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

src/hash.c needs a general cleanup. Part of this cleanup involves changing functions which take a Hash** argument and put a new Hash in it. These functions (parrot_new_hash_x, parrot_new_cstring_hash and parrot_new_pointer_hash) should instead return a Hash*.

Attachments

hash_cleanup.patch Download (17.3 KB) - added by cotto 5 years ago.

Change History

Changed 5 years ago by cotto

  • type changed from patch to cage
  • summary changed from [PATCH] src/hash.c cleanup: fix functions taking a Hash** arg to [CAGE] src/hash.c cleanup: fix functions taking a Hash** arg

Changed 5 years ago by cotto

Changed 5 years ago by cotto

The attached patch takes care of this. It also makes the following related changes: It changes create_hash to parrot_create_hash, making it non-static. Functions which used parrot_new_pmc_hash_x are switched to parrot_create_hash. It also removes the now-unused functions parrot_new_pmc_hash_x and parrot_new_hash_x.

Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

applied in r37543 with deprecation update in r37544.

Note: See TracTickets for help on using tickets.