Ticket #458 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

config/gen/makefiles.pm fails unless languages directory exists

Reported by: doughera Owned by:
Priority: critical Milestone:
Component: configure Version:
Severity: fatal Keywords:
Cc: Language:
Patch status: Platform:

Description

Now that all the languages are gone, and the languages/ directory is empty, the release tarball won't contain a languages/ directory. config/gen/makefiles.pm assumes there is such a directory, and tries to create languages/Makefile without first creating the languages/ directory.

I can think of three possible solutions: 1. config/gen/makefiles.pm should simply mkdir("languages", 0777). 2. lib/Parrot/Configure/Compiler.pm could do a splitpath() and then create the $directory if necessary. 3. The 'make release' step could include creating an empty languages directory.

I personally like #1 and have attached a simple patch.

Attachments

makefiles.p1 Download (0.6 KB) - added by doughera 5 years ago.

Change History

Changed 5 years ago by doughera

Changed 5 years ago by fperrad

other solution :

4. add a file languages/README

Changed 5 years ago by doughera

  • status changed from new to closed
  • resolution set to fixed

Solved differently in r37488, by getting rid of languages/Makefile altogether.

Note: See TracTickets for help on using tickets.