Ticket #490 (closed todo: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove support for non-default config options for Configure.pl's --gc

Reported by: coke Owned by: whiteknight
Priority: normal Milestone: 1.5
Component: configure Version:
Severity: medium Keywords: config
Cc: whiteknight Language:
Patch status: applied Platform:

Description

per allison, we don't need to support this config option for anything other than the default at this time.

While libc, malloc and malloc-trace are all documented as broken, we will still keep them in for a deprecation cycle.

Attachments

gc_options_remove.diff Download (7.2 KB) - added by jkeenan 5 years ago.
What I was trying to apply to trunk to merge in the 'gc_options_remove' branch
20090721.40201.formerge.txt Download (24.7 KB) - added by jkeenan 5 years ago.
'make' failure when trying to merge 'gc_options_remove' branch into trunk

Change History

Changed 6 years ago by coke

  • milestone set to 1.5

Changed 6 years ago by jkeenan

  • summary changed from Remove support for non-defeault config options for Configure.pl's --gc to Remove support for non-default config options for Configure.pl's --gc

Changed 6 years ago by jkeenan

  • cc jkeen@… added

Changed 6 years ago by jkeenan

  • cc jkeen@… removed
  • owner set to jkeenan
  • status changed from new to assigned

Changed 6 years ago by jkeenan

I have opened a branch, gc_options_remove, and prepared a branch therein. I'll merge and apply after the deprecation point.

Changed 5 years ago by jkeenan

  • component changed from none to configure

Changed 5 years ago by jkeenan

  • cc whiteknight added
  • patch set to applied

The deprecation point having passed, I went to merge the gc_options_remove branch into trunk. However, I experienced a build failure:

make: *** No rule to make target `src/gc/resources.o', needed by `blib/lib/libparrot.a'.  Stop.

I suspect that the source of this failure is the fact that, after I branched from trunk, another GC-related branch was merged into trunk. cc-ing whiteknight re that.

I am attaching two files: one is the svn diff that I tried to apply to trunk; the other is the output of make.

Thank you very much.
kid51

Changed 5 years ago by jkeenan

What I was trying to apply to trunk to merge in the 'gc_options_remove' branch

Changed 5 years ago by jkeenan

'make' failure when trying to merge 'gc_options_remove' branch into trunk

Changed 5 years ago by whiteknight

  • status changed from assigned to new
  • owner changed from jkeenan to whiteknight

I figured this would be a problem, but I should have looked at this branch before now. A lot of things inside the GC have changed past the point of recognizability. I'll take a look at the patch and adapt it for current Parrot.

Changed 5 years ago by whiteknight

  • status changed from new to closed
  • resolution set to fixed

committed in r40208. Thanks kid51!

Note: See TracTickets for help on using tickets.