Changes between Initial Version and Version 9 of Ticket #496

Show
Ignore:
Timestamp:
03/26/09 02:31:26 (13 years ago)
Author:
jkeenan
Comment:

I did a lot of fixing of these files to make them conform to our coding standards. But there was one case where what I did caused make to fail.

In src/io/socket_unix.c, the following line was judged to fail c_macro_args.t.

#  define SOCKADDR(p, t) ((struct sockaddr_in*)VTABLE_get_pointer(interp, PARROT_SOCKET((p))->t))

But changing it to the following caused make to fail:

#  define SOCKADDR(p, (t)) ((struct sockaddr_in*)VTABLE_get_pointer(interp, PARROT_SOCKET((p))->t))

So I reverted and, as a precaution, did so also in src/io/socket_win32.c. Can someone more familiar with this take a look?

Thank you very much.
kid51

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #496

    • Property status changed from new to reopened
    • Property severity changed from medium to fatal
    • Property component changed from none to core
    • Property patch changed from to applied
    • Property platform changed from to linux
    • Property keywords sockets added
    • Property summary changed from [PATCH] Ressurect socket io (unix only) to [PATCH] Resurrect socket io (unix only)
    • Property type changed from bug to patch
  • Ticket #496 – description

    initial v9  
    44 
    55--  
    6 Bacek 
     6Bacek[[BR]]