Ticket #519 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] (almost) switch *ManagedStruct to ATTRs

Reported by: cotto Owned by:
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

The attached patch does most of the work to convert uses of PMC_data by UnManagedStruct and ManagedStruct to ATTRs. Unfortunately there's some i386 jit code that pokes directly into PMC_data. The patch fixes some of the jit code, but I don't know x86 assembly well enough to fix everything. With the attached patch, all tests pass except for 8 tests in t/pmc/nci.t. I would appreciate help finishing this patch from someone with a little more knowledge of x86 and the jit code.

Attachments

managed_struct_attempt.patch Download (10.4 KB) - added by cotto 5 years ago.
almost working patch to update *ManagedStruct

Change History

Changed 5 years ago by cotto

almost working patch to update *ManagedStruct

Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

Thanks to tewk++ and his jit fix in r37897, the ManagedStruct family has been switched to ATTRs. This ticket is thereby resolved.

Note: See TracTickets for help on using tickets.