Ticket #533 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

headerizer not headerizing src/gc/gc_malloc.c

Reported by: coke Owned by: whiteknight
Priority: normal Milestone:
Component: coding_standards Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

t/codingstd/c_function_docs.t tries to check all the .c/.h files in the repository, including src/gc/gc_malloc.c, which currently fails the doc test

However, 'make headerizer' should be updating the function documentation in this file, and it's not (The docs are there, but the signature is slightly malformed, and headerizer isn't updating it.)

The file seems to contain headerizer directives, so I'd expect it to update the function docs here as it does for other files.

There may be more files of this type (with headerizer directives that aren't getting func docs updated), so this may help eliminate several remaining TODOs in t/codingstd/c_function_docs.t

Change History

  Changed 5 years ago by whiteknight

  • status changed from new to assigned
  • owner set to whiteknight

follow-up: ↓ 3   Changed 5 years ago by whiteknight

Is this still causing a problem? Since this file is code written externally it doesn't follow the same coding standards so I believe it was blacklisted from the c_function_docs.t tests. Is that not the case?

in reply to: ↑ 2   Changed 5 years ago by coke

Replying to whiteknight:

Is this still causing a problem? Since this file is code written externally it doesn't follow the same coding standards so I believe it was blacklisted from the c_function_docs.t tests. Is that not the case?

If it's external code, why is it marked for headerization, and copyright the Parrot Foundation?

  Changed 5 years ago by whiteknight

oh no, you're right. I got this confused with another file. Sorry.

  Changed 5 years ago by jkeenan

  • component changed from none to coding_standards

  Changed 5 years ago by chromatic

  • status changed from assigned to closed
  • resolution set to fixed

We don't even have src/gc/gc_malloc.c anymore.

Note: See TracTickets for help on using tickets.