Ticket #544 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

pmc2c ATTR type parsing is naive

Reported by: Infinoid Owned by: whiteknight
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

pmc2c can't handle an attr declaration that looks like:

    ATTR void (*custom_free_func)(void *ptr, void *priv);

cotto++ tells me this stuff is at lib/Parrot/Pmc2c/Parser.pm around line 133. I'm creating this ticket just so I won't forget about it.

Attachments

fix_attr_parsing.patch Download (3.9 KB) - added by whiteknight 5 years ago.
a first attempt to fix ATTR parsing, causes some test failures

Change History

Changed 5 years ago by whiteknight

a first attempt to fix ATTR parsing, causes some test failures

Changed 5 years ago by whiteknight

  • owner set to whiteknight

I've uploaded a first draft of a patch to fix this issue and allow arbitrary function pointers to be used as ATTR types. Unfortunately, this patch causes a few test failures that I haven't figured out yet.

Changed 5 years ago by whiteknight

  • status changed from new to closed
  • resolution set to fixed

Thanks to help from Infinoid++ I found the remaining problems, fixed them, and committed in r38353.

Note: See TracTickets for help on using tickets.