Ticket #546 (closed RFC: fixed)

Opened 5 years ago

Last modified 5 years ago

Parrot_ex_calc_handler_offset appears to be unused

Reported by: whiteknight Owned by: jkeenan
Priority: trivial Milestone:
Component: core Version:
Severity: low Keywords: exceptions
Cc: Language:
Patch status: Platform: all

Description

The function src/exceptions.c:Parrot_ex_calc_handler_offset appears to be unused in the repo. I can't find any uses for it, are there any applications using it externally? If not, I think we could remove it.

Change History

in reply to: ↑ description ; follow-up: ↓ 2   Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

Replying to whiteknight:

The function src/exceptions.c:Parrot_ex_calc_handler_offset appears to be unused in the repo.

This is what I get by grepping HEAD of trunk.

./src/exceptions.c:511:=item C<size_t Parrot_ex_calc_handler_offset(PARROT_INTERP)>
./src/exceptions.c:525:Parrot_ex_calc_handler_offset(PARROT_INTERP)
./src/exceptions.c:527:    ASSERT_ARGS(Parrot_ex_calc_handler_offset)
./docs/embed.pod:738:=item C<Parrot_ex_calc_handler_offset>
./include/parrot/exceptions.h:157:size_t Parrot_ex_calc_handler_offset(PARROT_INTERP)
./include/parrot/exceptions.h:238:#define ASSERT_ARGS_Parrot_ex_calc_handler_offset __attribute__unused__ int _ASSERT_ARGS_CHECK = (\

Let's say no one speaks up in its defense in seven days. I will then rip it out.

Thank you very much.
kid51

in reply to: ↑ 1   Changed 5 years ago by jkeenan

Replying to jkeenan:

Let's say no one speaks up in its defense in seven days. I will then rip it out.

12 days passed. So I have begun this work in the remove_Parrot_ex_calc_handler_offset branch.

  Changed 5 years ago by jkeenan

Ran both make test and make fulltest. The only test failure I got was the one which is afflicting all my testing on Linux/i386: the failure reported in TT #1393 in t/compilers/pge/pge_examples.t when run with --gc-debug. So there are no failures attributable to removing Parrot_ex_calc_handler_offset.

  Changed 5 years ago by jkeenan

Branch merged into trunk in r43340. Will keep ticket open for a few days for any complaints.

  Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

There have been no complaints in four days. Closing ticket.

Thank you very much.
kid51

Note: See TracTickets for help on using tickets.