Ticket #557 (closed todo: fixed)

Opened 4 years ago

Last modified 2 years ago

ucs2_decode_and_advance conditionally defined on ICU

Reported by: coke Owned by: NotFound
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

If ICU isn't available, this function (and others like it) should exist and throw an exception - currently they don't exist at all.

Change History

Changed 4 years ago by NotFound

  • owner set to NotFound
  • status changed from new to assigned

Those functions are used only in #if branches with ICU available, so not existing is the correct situation IMO because that way the compiler can check that they are not used. Unfortunatey, headerizer does not allow to conditionally define static functions and then the compilers warns about unused static functions.

As a temporary workaround, I make them PARROT_ASSERT(0) in r38154

Changed 2 years ago by nwellnhof

  • status changed from assigned to closed
  • resolution set to fixed

The Unicode iterators don't depend on ICU any more.

Note: See TracTickets for help on using tickets.