Ticket #582 (closed todo: wontfix)

Opened 5 years ago

Last modified 3 years ago

auto::sizes: Complete development of maxmin probes

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version:
Severity: medium Keywords: sizes intval floatval macro
Cc: NotFound, cotto, plobsing Language:
Patch status: Platform:

Description

In the course of work on TT #563, we recognized that there was certain code probing for minimum and maximum values for intval and floatval macros that was not yet working. This work needs to be completed.

The files intval_maxmin_c.in and floatval_maxmin_c.in are now found in config/auto/sizes/.

Change History

follow-up: ↓ 3   Changed 5 years ago by jkeenan

This is where things stood:

 $conf->cc_gen('config/auto/format/intval_maxmin_c.in');
 eval { $conf->cc_build(); };
 if ( $@ ) {
     $ivmin = '0';
     $ivmax = '0';
 }

...

 $conf->cc_gen('config/auto/format/floatval_maxmin_c.in');
 eval { $conf->cc_build(); };
 if ( $@ ) {
     $nvmin = '0';
     $nvmax = '0';
 }

  Changed 5 years ago by jkeenan

Remaining work on this ticket should take into account tests in t/steps/auto_sizes-01.t, including tests I just added to complete code coverage.

in reply to: ↑ 1   Changed 5 years ago by jkeenan

Replying to jkeenan:

This is where things stood: {{{ $conf->cc_gen('config/auto/format/intval_maxmin_c.in'); eval { $conf->cc_build(); }; if ( $@ ) { $ivmin = '0'; $ivmax = '0'; } ... $conf->cc_gen('config/auto/format/floatval_maxmin_c.in'); eval { $conf->cc_build(); }; if ( $@ ) { $nvmin = '0'; $nvmax = '0'; } }}}

Is there work still to be done on this ticket?

  Changed 5 years ago by jkeenan

  • component changed from none to configure

  Changed 3 years ago by jkeenan

  • status changed from new to assigned
  • cc plobsing added
  • owner set to jkeenan

  Changed 3 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to wontfix

Extensive work by plobsing++ in February of this year supersedes the code needing revision per this ticket. So I'm closing the ticket.

Thank you very much.

kid51

Note: See TracTickets for help on using tickets.