Ticket #6 (closed todo: fixed)

Opened 6 years ago

Last modified 6 years ago

remove VtableCache PMC

Reported by: allison Owned by:
Priority: trivial Milestone: 0.9.1
Component: none Version:
Severity: none Keywords:
Cc: Language:
Patch status: Platform:

Description

Double check that nothing is using the VtableCache PMC and delete it.

Attachments

patch.patch Download (2.6 KB) - added by jimmy 6 years ago.
patch2.patch Download (7.2 KB) - added by jimmy 6 years ago.

Change History

Changed 6 years ago by allison

  • type changed from bug to todo

Changed 6 years ago by coke

This PMC is used in src/pmc/object.pmc's share_ro vtable.

Changed 6 years ago by coke

  • keywords TODO added
  • summary changed from [TODO] remove VtableCache PMC to remove VtableCache PMC

Changed 6 years ago by coke

  • keywords TODO removed

Changed 6 years ago by coke

  • milestone set to 0.9.1

Changed 6 years ago by jimmy

Changed 6 years ago by cotto

jimmy's patch was applied in r35521.

Changed 6 years ago by jimmy

I uploaded patch2.patch to remove vtablecache.pmc

Changed 6 years ago by jimmy

seems that VtableCache is only used for STM.

Changed 6 years ago by jimmy

Changed 6 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

This PMC is history as of r35522. Many thanks to jimmy++ for his patches.

Changed 6 years ago by coke

We missed our deprecation window for taking this out by 0.9.0. (which is why I set the milestone to 0.9.1 on the ticket) Are we OK with breaking our normal cycle for this?

Changed 6 years ago by jimmy

should we revert it?

Changed 6 years ago by coke

Note that we also recently broke this rule for STM; this ticket may be covered by whatever extenuating circumstances allowed that to go through.

Note: See TracTickets for help on using tickets.