Test failures in make -k fulltest at r38415

[mikehh]

Running make -k fulltest on Kububtu Jaunty (9.04) AMD64 on r38415 - there are failures in codetest and examples_tests - all other tests PASS

summaries:

Test Summary Report
-------------------
t/codingstd/c_function_docs.t (Wstat: 256 Tests: 310 Failed: 1)
  Failed test:  68
  Non-zero exit status: 1
t/codingstd/copyright.t      (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
t/codingstd/pdd_format.t     (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/codingstd/perlcritic.t     (Wstat: 768 Tests: 306 Failed: 3)
  Failed tests:  1, 65, 170
  Non-zero exit status: 3
t/codingstd/trailing_space.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=33, Tests=670, 670 wallclock secs ( 1.57 usr  0.29 sys + 611.61 cusr  8.85 csys = 622.32 CPU)
Result: FAIL


Test Summary Report
-------------------
t/examples/pod.t      (Wstat: 7424 Tests: 171 Failed: 29)
  Failed tests:  4, 82-84, 86, 88, 90-97, 99, 101-102, 104
                106-107, 109-111, 113, 118-120, 122, 154
  Non-zero exit status: 29
Files=12, Tests=422, 276 wallclock secs ( 0.30 usr  0.08 sys + 19.37 cusr  7.22 csys = 26.97 CPU)
Result: FAIL

I was going to included a patch for some of the codingstd tests that I pasted to nospace, but Coke fixed it at r38422

specifically
t/codingstd/pdd_format.t
t/codingstd/perlcritic.t
t/codingstd/trailing_space.t

perlcritic fails for the same as trailing_space

---

The other failures in codetest are:

#   Failed test 'src/dynext.c'
#   at t/codingstd/c_function_docs.t line 83.
# 1 function(s) lacking documentation:
# src/dynext.c (missing)
# PARROT_WARN_UNUSED_RESULT
# PARROT_CAN_RETURN_NULL
# static PMC*
# is_loaded(PARROT_INTERP, ARGIN(STRING *path))
# 
# 
# Looks like you failed 1 test of 310.
t/codingstd/c_function_docs.t .. 

maybe this needs a TODO?

and

#   Failed test 'Duplicate Copyright statements'
#   at t/codingstd/copyright.t line 162.
# Duplicate copyright statement found in 4 files:
# /home/mhj64/parrot/compilers/imcc/main.c
# /home/mhj64/parrot/compilers/imcc/parser_util.c
# /home/mhj64/parrot/compilers/imcc/imcc.y
# /home/mhj64/parrot/compilers/imcc/imcc.l
# Please get copyright assigned to Parrot Foundation
# and remove alternate notice; or remove duplicated
# notice for Parrot Foundation.
# Looks like you failed 1 test of 3.
t/codingstd/copyright.t ........ 

this is due to copyright statements:
* Copyright (C) 2002 Melvin Smith <melvin.smith@…>

---

All but one of the examples_tests failures are from docs/book/ch09_pasm.pod, the remaining failure is in docs/book/ch03_pir.pod:

error:imcc:syntax error, unexpected '=', expecting PARROT_OP ('=')
	in file '/tmp/_JBD5LueTL.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:120'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('newsub')
	in file '/tmp/Vl9OirSy2V.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2297'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('new_pad')
	in file '/tmp/kBaz_nbJ05.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2311'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('newsub')
	in file '/tmp/S1iSmJCrT5.pasm' line 5

#   Failed test 'docs/book/ch09_pasm.pod:2375'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('compile')
	in file '/tmp/pCnWEmbWNC.pasm' line 4

#   Failed test 'docs/book/ch09_pasm.pod:2431'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('newsub')
	in file '/tmp/pkdvOuu2ka.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2483'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('newsub')
	in file '/tmp/DL1nc5Uo2Y.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2591'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'invoke' (invoke<0>) was not found. Check the type and number of the arguments
	in file '/tmp/YBXb1lGTfV.pasm' line 12

#   Failed test 'docs/book/ch09_pasm.pod:2654'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:The opcode 'invoke' (invoke<0>) was not found. Check the type and number of the arguments
	in file '/tmp/bgWL6uqYnP.pasm' line 7

#   Failed test 'docs/book/ch09_pasm.pod:2761'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:The opcode 'invoke' (invoke<0>) was not found. Check the type and number of the arguments
	in file '/tmp/5rmxSRjzsw.pasm' line 6

#   Failed test 'docs/book/ch09_pasm.pod:2775'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected DOT, expecting PARROT_OP ('.')
	in file '/tmp/9QSRrZqSwr.pasm' line 3

#   Failed test 'docs/book/ch09_pasm.pod:2801'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'invokecc' (invokecc<0>) was not found. Check the type and number of the arguments
	in file '/tmp/6mOqON2XwW.pasm' line 7

#   Failed test 'docs/book/ch09_pasm.pod:2817'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:The opcode 'set_global_p_sc' (set_global<2>) was not found. Check the type and number of the arguments
	in file '/tmp/YXbKeKLlYq.pasm' line 6

#   Failed test 'docs/book/ch09_pasm.pod:2831'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected DOT, expecting PARROT_OP ('.')
	in file '/tmp/5bxfsjYmqn.pasm' line 3

#   Failed test 'docs/book/ch09_pasm.pod:2847'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('find_type')
	in file '/tmp/RLfgHa1Zk7.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2907'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('classoffset')
	in file '/tmp/YOkjuQjCwg.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2938'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'setattribute_p_i_p' (setattribute<3>) was not found. Check the type and number of the arguments
	in file '/tmp/VeA0iyXyNN.pasm' line 4

#   Failed test 'docs/book/ch09_pasm.pod:2954'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('classoffset')
	in file '/tmp/Qk6S7M7AVP.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:2977'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'getattribute_p_p_i' (getattribute<3>) was not found. Check the type and number of the arguments
	in file '/tmp/3bnSLfq1Fr.pasm' line 3

#   Failed test 'docs/book/ch09_pasm.pod:2997'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('classoffset')
	in file '/tmp/bZNic7BKbK.pasm' line 3

#   Failed test 'docs/book/ch09_pasm.pod:3015'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'callmethodcc' (callmethodcc<0>) was not found. Check the type and number of the arguments
	in file '/tmp/8Vev4GA7lD.pasm' line 5

#   Failed test 'docs/book/ch09_pasm.pod:3051'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected DOT, expecting PARROT_OP ('.')
	in file '/tmp/bBhNGIMfHE.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:3080'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('find_type')
	in file '/tmp/5d7DqKpq9f.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:3095'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'new_p_i' (new<2>) was not found. Check the type and number of the arguments
	in file '/tmp/n2Pb5GB9QV.pasm' line 3

#   Failed test 'docs/book/ch09_pasm.pod:3117'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected DOT, expecting PARROT_OP ('.')
	in file '/tmp/dXcF56uvdT.pasm' line 4

#   Failed test 'docs/book/ch09_pasm.pod:3181'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('find_type')
	in file '/tmp/uIpGfEBywd.pasm' line 2

#   Failed test 'docs/book/ch09_pasm.pod:3200'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:The opcode 'callmethodcc' (callmethodcc<0>) was not found. Check the type and number of the arguments
	in file '/tmp/9Znw2abE2z.pasm' line 10

#   Failed test 'docs/book/ch09_pasm.pod:3210'
#   at t/examples/pod.t line 51.
#          got: '512'
#     expected: '0'
error:imcc:syntax error, unexpected IDENTIFIER, expecting PARROT_OP ('find_type')
	in file '/tmp/w7FR3C3iBi.pasm' line 5

#   Failed test 'docs/book/ch09_pasm.pod:3246'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
error:imcc:syntax error, unexpected ADV_INVOCANT, expecting '\n' (':invocant')
	in file '/tmp/pfFSmsPEis.pir' line 8

#   Failed test 'docs/book/ch03_pir.pod:1675'
#   at t/examples/pod.t line 51.
#          got: '256'
#     expected: '0'
# Looks like you failed 29 tests of 171.
t/examples/pod.t ........ 
Dubious, test returned 29 (wstat 7424, 0x1d00)
Failed 29/171 subtests 

[coke]

All the failures here except for t/examples/pod.t are resolved. (Some were likely due to an issue with the tests that caused them to fail on perls before 5.8.9).

We can resolve the example POD failures once we know how the known TODO PIR sections should be marked so as not to conflict with 'make html'.

Allison, ISTR that having a space in the target, like:

=begin PIR TODO

was a problem.

is

=begin PIR_TODO

ok?

[coke]

t/examples/pod.t is passing again. See the perldoc for that file for information answer the question in the last post regarding valid target syntax.