Ticket #636 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Off-end-of-array access in Parrot_OrderedHash_visit

Reported by: skids Owned by: NotFound
Priority: normal Milestone:
Component: core Version: 1.1.0
Severity: high Keywords: rakudo build segmentation fault freeze
Cc: Language:
Patch status: applied Platform: all

Description

Parrot_OrderedHash_visit goes one past the end of the bucket store. Actually it usuaully visits one bucket off the free list, but when the bucket store is full this can go off the end.

Oddly, this problem only seems to surface when trying to build rakudo with hash.c INITIAL_BUCKETS set to 4, and the failures are spurious.

You'd think something like this would have caused more obvious problems before now.

Attachments

parrot_segv_OH_visit.patch Download (0.5 KB) - added by skids 6 years ago.
patch to fix 636

Change History

Changed 6 years ago by skids

patch to fix 636

Changed 6 years ago by NotFound

  • status changed from new to assigned
  • owner set to NotFound
  • patch changed from new to applied

Applied with cosmetic changes in r38461

Ticket left open for a few days just in case.

Changed 6 years ago by NotFound

  • status changed from assigned to closed
  • resolution set to fixed

No complaints, closing ticket.

Note: See TracTickets for help on using tickets.