Ticket #639 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Usage information for command line options

Reported by: Klaus Owned by:
Priority: minor Milestone:
Component: none Version: 1.1.0
Severity: low Keywords: command line option
Cc: Language:
Patch status: Platform:

Description

Command line options like --CGP-core or --jit-core aren't accepted anymore. The usage information provided by ./parrot --help should reflect that, also, of course the parrot documention.

Attachments

commandlineoptions.patch Download (3.4 KB) - added by Klaus 6 years ago.
patch for 3 files

Change History

in reply to: ↑ description   Changed 6 years ago by jkeenan

Replying to Klaus:

Command line options like --CGP-core or --jit-core aren't accepted anymore. The usage information provided by ./parrot --help should reflect that, also, of course the parrot documention.

Picking out one of those options, --CGP-core, and grepping the repository, we can identify the files which likely would have to change:

$ fns . | xargs grep -n 'CGP-core'
./compilers/imcc/main.c:224:    "    --CGP-core\n"
./tools/dev/parrot-fuzzer:65:include C<--CGP-core>, C<--fast-core>, C<--computed-goto-core>, C<--jit-core>,
./docs/book/appc_command_line_options.pod:278:=item --CGP-core
./docs/running.pod:158:=item --CGP-core

Would you be able to supply a patch?

Thank you very much.
kid51

Changed 6 years ago by Klaus

patch for 3 files

  Changed 6 years ago by Klaus

Attached a patch for three files:

 compilers/imcc/main.c                   |    9 +-----
 docs/book/appc_command_line_options.pod |   44 ++++++++++++++++++++++++--------
 docs/running.pod                        |   25 ------------------
 3 files changed, 35 insertions(+), 43 deletions(-)

Please note that I'm not familiar with the tool chain and the parrot source code.

I'm not able to change the parrot-fuzzer tool.

The corresponding passage of parrot --help looks now:

   <Run core options>
    -R --runcore slow|bounds|fast|jit|cgoto|cgp|cgp-jit
    -R --runcore switch|switch-jit|trace|exec|gcdebug
    -p --profile
    -t --trace [flags]

  Changed 6 years ago by chromatic

  • status changed from new to closed
  • resolution set to fixed

Thanks, applied as 39413 (with a patch to parrot-fuzzer).

Note: See TracTickets for help on using tickets.