Ticket #640 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Some vtable functions stil used externally

Reported by: NotFound Owned by: bacek
Priority: normal Milestone:
Component: core Version: 1.1.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description (last modified by NotFound) (diff)

src/jit/i386/jit_emit.h declares and uses Parrot_FixedIntegerArray_get_integer_keyed_int and Parrot_FixedIntegerArray_set_integer_keyed_int

src/pmc_freeze.c declares and uses Parrot_default_thaw and Parrot_default_thawfinish

The declarations used prefixes that declared them as extern "C" in c++ builds. I've fixed that in r38491, but the desired solution is to not use directly vtable functions at all.

Change History

Changed 6 years ago by NotFound

  • description modified (diff)

Changed 6 years ago by bacek

  • owner set to bacek

I'm going to fix it as part of #631.

Changed 6 years ago by bacek

  • status changed from new to closed
  • resolution set to fixed

It's fixed now. VTABLE functions declared static, so it's virtually impossible to use them externally.

Note: See TracTickets for help on using tickets.