Ticket #645 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH] remove "." from architecture names

Reported by: rrauenza Owned by:
Priority: normal Milestone:
Component: configure Version: 1.1.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: unix

Description (last modified by NotFound) (diff)

This fixes arch.pm on hpux, which is built with the following architecture id's:

@INC:

/usr/local/lib/perl5/5.10.0/IA64.ARCHREV_0 /usr/local/lib/perl5/5.10.0 /usr/local/lib/perl5/site_perl/5.10.0/IA64.ARCHREV_0 /usr/local/lib/perl5/site_perl/5.10.0

The "." gets propagated into config.h as part of a #define identifier, which is illegal. So I turn the "." into "_". A more robust solution would be to check for any characters not allowed in a #define, but I'm reluctant to make that large of a change.

--- config/auto/arch.pm (revision 38492) +++ config/auto/arch.pm (working copy) @@ -39,6 +39,7 @@

$verbose and print "\n";

my $archname = $conf->data->get('archname');

+ $archname =~ s|\.|_|g;

my ( $cpuarch, $osname ) = split( /-/, $archname );

if ($verbose) {

Attachments

patch.txt Download (444 bytes) - added by rrauenza 6 years ago.

Change History

Changed 6 years ago by rrauenza

Changed 6 years ago by NotFound

  • status changed from new to closed
  • resolution set to fixed
  • description modified (diff)
  • patch set to applied

Thanks! Applied with the addition of a comment in r38512, other change commited with this by mistake reverted in r38513.

Note: See TracTickets for help on using tickets.