Ticket #653 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] remove "." from architecture names

Reported by: rrauenza Owned by: Infinoid
Priority: normal Milestone:
Component: none Version: 1.1.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

Referencing bug #645 (I couldn't reopen it)

The s|\.|_|g was put into the wrong place. It needs to go above the split -- immediately after the assignment.

i.e.,

    my $archname = $conf->data->get('archname');

    # This was added to convert IA64.ARCHREV_0 on HP-UX, TT #645
    $archname =~ s|\.|_|g;

    my ( $cpuarch, $osname ) = split( /-/, $archname );

Change History

in reply to: ↑ description   Changed 5 years ago by Infinoid

  • owner set to Infinoid

Replying to rrauenza:

Referencing bug #645 (I couldn't reopen it)

Hi! Actually you can still reply to a bug after it's closed, and a dev can reopen it if necessary. But this works fine too.

The s|\.|_|g was put into the wrong place. It needs to go above the split -- immediately after the assignment. i.e., {{{ my $archname = $conf->data->get('archname'); # This was added to convert IA64.ARCHREV_0 on HP-UX, TT #645 $archname =~ s|\.|_|g; my ( $cpuarch, $osname ) = split( /-/, $archname ); }}}

Thanks, I've applied this as r38625. Hopefully we've got it right this time, please let us know either way.

Mark

  Changed 5 years ago by Infinoid

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Hearing no complaints, I'm closing this ticket.

Thanks!

Note: See TracTickets for help on using tickets.