Ticket #658 (closed patch: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH] Rewrite of t/pmc/ro.t to PIR

Reported by: bobw Owned by:
Priority: normal Milestone:
Component: none Version: 1.1.0
Severity: medium Keywords: ro.t PIR
Cc: jkeenan, chromatic, rgrjr, allison, cotto Language:
Patch status: new Platform: all

Description

Please find enclosed a patch to convert t/pmc/ro.t from Perl to PIR.

bob@eeepcenc:~/src/parrot/t/pmc$ diffstat ro.t.patch

ro.t | 156

+++++++++++++++++++++++++------------------------------------------

1 file changed, 60 insertions(+), 96 deletions(-)

bob@eeepcenc:~/src/parrot/t/pmc$

Please review carefully. It is my first patch submission!

Bob

Attachments

ro.t.patch Download (5.8 KB) - added by bobw 6 years ago.
A patch file to convery from Perl to PIR

Change History

Changed 6 years ago by bobw

A patch file to convery from Perl to PIR

Changed 6 years ago by jkeenan

  • cc jkeenan, chromatic, rgrjr, allison, cotto added
  • patch set to new

This looks very interesting. It would benefit from a coda similar to that in t/pmc/object.t identifying the file as PIR to text editors.

The biggest problem I see to applying it is that we really haven't resolved the issue in  RT #46821: Should readonly be deep or shallow?. I think you should leave that comment in.

But, of course, what we should really do is to resolve the issues raised in that RT. I am CC-ing some contributors to that discussion to this TT.

Thank you very much.
kid51

Changed 6 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

The patch looks like a straightforward conversion to PIR, mod a few housekeeping changes. I removed the reference to Perl6, added a coda and a note about RT #46821 and applied the patch as r38684. Thanks for contributing!

I'll ask about the RT at the next #ps.

Note: See TracTickets for help on using tickets.