Ticket #663 (closed bug: fixed)
src/pmc.c:pmc_free() is unused
Reported by: | whiteknight | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | 1.3 |
Component: | none | Version: | 1.1.0 |
Severity: | medium | Keywords: | |
Cc: | Language: | ||
Patch status: | Platform: |
Description
The function pmc_free() in src/pmc.c is currently unused. Besides that, I don't think it does the right thing anyway: it doesnt call the destroy VTABLE for types that need it before returning the header to the GC.
In general, I don't think we should have any cases where PMCs are explicitly freed, the GC should be handling that so we don't end up with cases where things are pointing to a PMC that has been recycled. I suggest we delete this function outright. Since it isn't used from anywhere and since it doesn't work anyway (so nobody should be relying on it) I don't know if we need a deprecation cycle for it.
Change History
Note: See
TracTickets for help on using
tickets.