Ticket #678 (closed cage: fixed)

Opened 13 years ago

Last modified 13 years ago

Is tools/dev/parrot_8.supp still needed?

Reported by: jkeenan Owned by: jkeenan
Priority: minor Milestone:
Component: none Version: 1.1.0
Severity: low Keywords: valgrind
Cc: Language:
Patch status: Platform:


(I posed this question in  RT #41912 five months ago but got no response. I want to close that ticket because its main concerns have been addressed. So I am re-posing the question here in Trac.)

Under tools/dev/ we have two files which appear to be Valgrind suppression files:

$ ll tools/dev/*supp
-rw-r--r--   1 jimk  jimk  1414 Mar  8 09:25 tools/dev/parrot.supp
-rw-r--r--   1 jimk  jimk  5186 Jul 20  2008 tools/dev/parrot_8.supp

parrot_8.supp has not been functionally changed since it was first added to the repository:

r14325 | leo | 2006-08-23 07:18:24 -0400 (Wed, 23 Aug 2006) | 3 lines

* fix off by one set allocation in reg_alloc
* add valgrind suppression file for 64bit parrot

Is parrot_8.supp still needed? Or has it been subsumed into parrot.supp?

Valgrind users, please comment.

Thank you very much..

Change History

Changed 13 years ago by jkeenan

Still need comment from Valgrind users. chromatic? whiteknight? petdance?

Changed 13 years ago by Infinoid

I use parrot.supp on amd64. There's no reason why the file can't be shared for all platforms. In fact, I've recently (r39495, r39856) added a bunch of linux/amd64-specific stuff to make it run a little more smoothly here.

Killing parrot_8.supp gets a +1 from me.

Changed 13 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

Changed 13 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

tools/dev/parrot_8.supp has not found any defenders. Bye-bye!

Removed in r40095. Closing ticket.


Note: See TracTickets for help on using tickets.