Ticket #680 (closed patch: done)

Opened 6 years ago

Last modified 5 years ago

Add a setstdin opcode

Reported by: flh Owned by: NotFound
Priority: normal Milestone:
Component: none Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

Parrot currently has setstdout and setstderr opcodes, but no setstdin. This patch adds this opcode.

The documentation used to refer to the old ParrotIO PMC instead of FileHandle: this patch also contains the renaming.

Attachments

setstdin.patch Download (3.7 KB) - added by flh 6 years ago.
Add a setstdin opcode + docs update
doc_update.patch Download (1.4 KB) - added by flh 6 years ago.
Change ParrotIO to FileHandle
remove_setstdin_doc.patch Download (462 bytes) - added by flh 6 years ago.
Left by mistake the doc for "setstdin": patch removes it, me--

Change History

Changed 6 years ago by flh

Add a setstdin opcode + docs update

  Changed 6 years ago by coke

+1

in reply to: ↑ description   Changed 6 years ago by NotFound

Parrot currently has setstdout and setstderr opcodes, but no setstdin. This patch adds this opcode.

I propose to deprecate setstdout, setstderr, getstdin, getstdout and getstderr instead of adding this one. We have the stdhandle method in the ParrotInterpreter PMC that does all this tasks, and they are not so critical in speed nor so frequently used to justify the need for opcodes.

  Changed 6 years ago by flh

Agree with deprecating these ops: I did not know the stdhandle method.

I'm attaching a new patch, which only does the doc update (renaming ParrotIO to FileHandle, in sections about these ops).

Changed 6 years ago by flh

Change ParrotIO to FileHandle

  Changed 6 years ago by NotFound

Tanks, applied in r39053

Changed 6 years ago by flh

Left by mistake the doc for "setstdin": patch removes it, me--

  Changed 6 years ago by NotFound

  • status changed from new to assigned
  • owner set to NotFound

Decision at today parrotsketch has been to implement the setstdin opcode and keep the others.

  Changed 5 years ago by NotFound

  • status changed from assigned to closed
  • resolution set to done
  • patch changed from new to applied

Patch implementing setstdin applied with cosmetic changes in r39224.

I left only 'PMC' in the pod of the set opcodes. Is what the code really does, after all.

Closing ticket.

Note: See TracTickets for help on using tickets.