Ticket #690 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

manifest_tests Makefile target does not work in release tarball

Reported by: Infinoid Owned by: jkeenan
Priority: normal Milestone:
Component: none Version: 1.1.0
Severity: medium Keywords: manifest release tarball
Cc: Language:
Patch status: applied Platform:

Description

parrot-1.2.0 % prove t/manifest
t/manifest/01-basic.t ............ skipped: (no reason given)
t/manifest/02-regenerate_file.t .. skipped: (no reason given)
t/manifest/03-regenerate_skip.t .. skipped: (no reason given)
t/manifest/04-alt_file.t ......... skipped: (no reason given)
t/manifest/05-alt_skip.t ......... skipped: (no reason given)
Files=5, Tests=0,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.29 cusr  0.04 csys =  0.38 CPU)
Result: NOTESTS

This is run as part of "fulltest", and the NOTESTS return value is apparently considered "false" by GNU make. This causes failure when following step 6 of docs/project/release_manager_guide.pod (testing the tarball).

I was able to verify through other means that all the files mentioned in MANIFEST are present, and that everything seems to work fine. This is just an interruption of an otherwise smooth test process.

Change History

  Changed 5 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

in reply to: ↑ description   Changed 5 years ago by jkeenan

  • patch set to applied

Replying to Infinoid:

Fixed in r39000. What we'll do is this: When working in a release tarball, rather than saying skip_all, we'll skip all but one test -- a pass(). The test file will register PASS and keep make manifest_tests -- and, by extension, make fulltest -- happy.

Thank you very much.
kid51

  Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.