Ticket #733 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

Branch cleanup: pdd30install_stage4

Reported by: jkeenan Owned by: jkeenan
Priority: minor Milestone:
Component: install Version: 1.2.0
Severity: low Keywords: branch
Cc: Language:
Patch status: applied Platform:

Description

Using these commands:

svn log https://svn.parrot.org/parrot/branches/pdd30install_stage4/ --stop-on-copy > ./pdd30install_stage4.log

svn diff https://svn.parrot.org/parrot/trunk@35113 https://svn.parrot.org/parrot/branches/pdd30install_stage4@HEAD > ./pdd30install_stage4.diff

I inspected what was done in this branch to ascertain whether the branch is removable. See attached pdd30install_stage4.diff. My estimate is that the only thing proposed to be done in this branch which has not subsequently been in trunk is this deletion from config/init/defaults.pm:

-        # for cygwin
-        cygchkdll => '',
-

1. Is it okay to delete this branch?

2. The string cygchkdll occurs nowhere else in our source code but config/init/defaults.pm. Is it okay to delete it from that file?

Thank you very much.

kid51

Attachments

Change History

  Changed 5 years ago by jkeenan

  • status changed from new to assigned

follow-up: ↓ 3   Changed 5 years ago by doughera

If that diff is all that's left, then, yes, it's certainly fine to delete this branch.

in reply to: ↑ 2   Changed 5 years ago by jkeenan

  • patch set to applied

Replying to doughera:

If that diff is all that's left, then, yes, it's certainly fine to delete this branch.

Thanks for the feedback.

I deleted the pdd30install_stage4 branch in r39373.

I deleted the assignment of an empty string to cygchkdll in config/init/defaults.pm. I then configured, built and tested -- albeit on Linux, not on Cygwin. Results favorable. I then committed to trunk in r39374.

I couldn't test on Cygwin. But we are getting steady Smolder reports on Cygwin (e.g.,  this Smolder report on Cygwin), so we should be able to determine within 24 hours whether this change negatively affects Parrot on that OS.

I'll resolve the ticket once we see some Smolder reports.

Thank you very much.
kid51

  Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Thanks to ksethura we have been getting steady Smolder reports on Cygwin, such as  report 23175. One test file, /compilers/imcc/syn/file.t, is failing completely on Cygwin -- but it was doing that before I applied the patch. So I infer that the patch did not harm, and am now resolving this ticket.

Thank you very much.
kid51

Note: See TracTickets for help on using tickets.