Changes between Initial Version and Version 1 of Ticket #746

Show
Ignore:
Timestamp:
06/08/09 16:49:03 (6 years ago)
Author:
jkeenan
Comment:

Replying to coke:

{{{ $ prove t/codingstd/pdd_format.t [15:14:48] t/codingstd/pdd_format.t .. 1/1 # Failed test ' # pdd19_pir.pod has 1 lines > 78 chars: 849 # # ' # at t/codingstd/pdd_format.t line 42. # Looks like you failed 1 test of 1. [15:14:48] t/codingstd/pdd_format.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests [15:14:51] Test Summary Report ------------------- t/codingstd/pdd_format.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 3 wallclock secs ( 0.02 usr 0.00 sys + 2.95 cusr 0.18 csys = 3.15 CPU) Result: FAIL }}} This line was changed in this commit: {{{ $ svn log -r 39348 | more ------------------------------------------------------------------------ r39348 | allison | 2009-06-03 02:12:51 +0200 (Wed, 03 Jun 2009) | 3 lines [pdd] Using "flag" to talk about the ':foo' subroutine feature selectors is vague, changing to the earlier term "modifier". }}}

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #746

    • Property cc jkeenan added
  • Ticket #746 – description

    initial v1  
    2121}}} 
    2222 
    23 This line was changed in this commit: 
    24 {{{ 
    25 $ svn log -r 39348 | more 
    26 ------------------------------------------------------------------------ 
    27 r39348 | allison | 2009-06-03 02:12:51 +0200 (Wed, 03 Jun 2009) | 3 lines 
     23Infinoid and I noticed this failure in the course of working on other things on Saturday morning. 
    2824 
    29 [pdd] Using "flag" to talk about the ':foo' subroutine feature selectors 
    30 is vague, changing to the earlier term "modifier". 
    31 }}} 
     25Could we get by with shortening the string 'modifier' in two locations in the failing line?  That should get us below the 78-char max. 
     26 
     27kid51