Ticket #749 (closed cage: fixed)

Opened 6 years ago

Last modified 4 years ago

[CAGE] factor Packfile_unpack into validation and unpacking functions

Reported by: cotto Owned by: whiteknight
Priority: minor Milestone:
Component: core Version: 1.2.0
Severity: medium Keywords: packfile,pmc,freeze,thaw
Cc: plobsing, chromatic Language:
Patch status: Platform:

Description

Packfile_unpack has some code that could be put to use in the thawing portion of ft_init in src/pmc_freeze.c. It would be nice if Packfile_unpack could be factored into two separate functions; one to validate a packfile and one to do the actual unpacking. That would allow ft_init to reuse the validation code, adding some more sanity checks to PMC thawing.

Change History

Changed 5 years ago by jkeenan

  • component changed from none to core

Changed 4 years ago by jkeenan

  • cc plobsing, chromatic added

Is this ticket still pertinent?

(cc-ing committers who have worked on src/pmc_freeze.c.)

Changed 4 years ago by whiteknight

  • owner set to whiteknight

This ticket does still look useful. I'm turning it into a GCI task.

Changed 4 years ago by aantn

I'm working on this for GCI.

 https://github.com/parrot/parrot/pull/86

Changed 4 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

task completed, tt closed

Note: See TracTickets for help on using tickets.