Ticket #759 (closed todo: fixed)

Opened 6 years ago

Last modified 5 years ago

Reconsider one-test-file-per-PMC policy

Reported by: jkeenan Owned by: coke
Priority: normal Milestone:
Component: coding_standards Version: 1.2.0
Severity: medium Keywords:
Cc: coke, whiteknight, particle Language:
Patch status: Platform:

Description

test_file_coverage.t was added by particle in January 2006.

------------------------------------------------------------------------
r11227 | particle | 2006-01-17 14:26:47 -0500 (Tue, 17 Jan 2006) | 3 lines

tests: test file coverage
~ tests that all PMC classes have test files

It requires that files matching src/pmc/*.pmc, src/dynpmc/*.pmc and src/dynoplibs/*.ops have corresponding test files in t/pmc, t/dynpmc and t/dynoplibs, respectively.

The coding standard implied by this test file was little noticed and uncontroversial until just this week. However, discussion on the parrot-dev list suggests that certain PMCs should be exempt from this requirement. I am creating this ticket to track discussion of the issue.

Thank you very much.
kid51

Change History

Changed 5 years ago by jkeenan

  • cc particle added

Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • component changed from none to coding_standards

Changed 5 years ago by jkeenan

  • status changed from new to assigned

Changed 5 years ago by coke

  • status changed from assigned to new
  • owner changed from jkeenan to coke

I removed the test in rXXX

Going forward, let's look to code coverage to insure we're testing all the PMC code we have. Having a file per PMC doesn't do anything to insure actual functional testing.

Changed 5 years ago by coke

  • status changed from new to closed
  • resolution set to fixed

Whoops, clicked button too soon. Removed in r42333.

Note: See TracTickets for help on using tickets.