Ticket #772 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[BUG] Duplicate identifier in PGE;Perl6Grammar.compile

Reported by: NotFound Owned by: pmichaud
Priority: normal Milestone:
Component: none Version: 1.2.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

In the compile method at runtime/parrot/library/PGE/Perl6Grammar.pir:139 the symbol namespace is declared as local pmc and later as local string

This is a blocker for TT #767

Change History

follow-up: ↓ 2   Changed 5 years ago by pmichaud

  • owner set to pmichaud
  • status changed from new to assigned

in reply to: ↑ 1   Changed 5 years ago by bacek

Replying to pmichaud:

Any objections against this patch?

diff --git a/runtime/parrot/library/PGE/Perl6Grammar.pir b/runtime/parrot/library/PGE/Perl6Grammar.pir
index e6fe3f0..43d5c66 100644
--- a/runtime/parrot/library/PGE/Perl6Grammar.pir
+++ b/runtime/parrot/library/PGE/Perl6Grammar.pir
@@ -140,9 +140,9 @@ the output to the correct output file.
     .param pmc source
     .param pmc adverbs         :slurpy :named
 
-    .local pmc nstable, namespace
+    .local pmc nstable, ns
     nstable = new 'Hash'
-    namespace = new 'String'
+    ns = new 'String'
     $P0 = new 'Hash'
     $P1 = new 'CodeString'
     $P0['optable'] = $P1
@@ -165,7 +165,7 @@ the output to the correct output file.
     $S0 = match['cmd']
     concat $S0, '_stmt'
     $P0 = find_name $S0
-    $P0(match, namespace, nstable)
+    $P0(match, ns, nstable)
     goto stmt_loop
   stmt_end:
 

-- Bacek

  Changed 5 years ago by pmichaud

  • status changed from assigned to closed
  • resolution set to fixed

Patch applied in r39972, thanks!

Closing ticket.

Note: See TracTickets for help on using tickets.