Ticket #788 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

Audit PDD30 compliance

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone:
Component: install Version: trunk
Severity: medium Keywords: install PDD30
Cc: pmichaud wayland particle Language:
Patch status: applied Platform: all

Description

Parrot Design Document 30: Installation (docs/pdds/pdd30_install.pod) defines the locations where Parrot is to be installed. To help resolve other Trac tickets concerned with installation-related issues, it would be helpful to audit our current compliance with PDD30. Assuming that you configure as follows:

perl Configure.pl --prefix=/path/to/install/tree

... and then call make, what happens when you then call make install and/or make install-dev? Is the resulting file tree under /path/to/install/tree that which you would predict on the basis of PDD30?

We need a report that identifies all files installed and flags those files which do not clearly match the criteria established in PDD 30.

Report should be provided as an attachment to this TT.

Thank you very much.
kid51

Attachments

dev_installed_sorted.txt Download (28.1 KB) - added by jkeenan 5 years ago.
Sorted list of files installed via 'make install_dev' on Linux/i386
tt788_doco_changes.patch Download (0.5 KB) - added by wayland 5 years ago.
Documentation patch

Change History

Changed 5 years ago by jkeenan

Sorted list of files installed via 'make install_dev' on Linux/i386

  Changed 5 years ago by allison

Reading through the list you have there and through PDD30, yes, the current install is compliant with PDD30. (It's not printing the prefix in that output, so things that start with lib/ are actually installed in /usr/lib/.)

Two install directories aren't mentioned in the PDD, and that's the location of C header files (/usr/include/parrot/<version>/) and the location of PMC source files needed for building dynamic PMCs (/usr/src/parrot/<version>/).

Changed 5 years ago by wayland

Documentation patch

follow-up: ↓ 3   Changed 5 years ago by wayland

[12:44] <wayland76> kid51: What needs to happen to https://trac.parrot.org/parrot/ticket/788 ? Do we just need to update the PDD? And if so, am I right in guessing that it's PDD30 that needs updating? [12:48] <kid51> wayland76: AFAICT, if PDD30 were updated to reflect allison's concerns in her 2nd paragraph, the ticket would be closable

In relation to the above IRC exchange, I attach the previous patch.

in reply to: ↑ 2   Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • type changed from todo to patch
  • patch set to applied

Replying to wayland:

[12:44] <wayland76> kid51: What needs to happen to https://trac.parrot.org/parrot/ticket/788 ? Do we just need to update the PDD? And if so, am I right in guessing that it's PDD30 that needs updating? [12:48] <kid51> wayland76: AFAICT, if PDD30 were updated to reflect allison's concerns in her 2nd paragraph, the ticket would be closable In relation to the above IRC exchange, I attach the previous patch.

wayland,

Thanks for your patch. I decided to try an installation and to match up the results with what I would have expected based on the patch.

Since I'm not about to install Parrot for real unless I know I can uninstall it, I configured with a prefix=pseudoinstall. Mindful of what Allison wrote above re prefixes, here's where I would have expected various file types to be installed:

Type               True install                     Prefix install

C header files     /usr/include/parrot/1.4.0-devel  /pseudoinstall/include/parrot/1.4.0-devel

PMC source files   /usr/src/parrot/1.4.0-devel      /psuedoinstall/src/parrot/1.4.0-devel/

I did indeed find the headers and the .pmc files beneath the expected directories, albeit in both cases the actual files were one level farther down:

[li11-226:pseudoinstall] 544 $ ll include/parrot/1.4.0-devel/   
total 3
drwxr-xr-x 4 jimk jimk 2048 Jul 22 19:24 parrot
drwxr-xr-x 2 jimk jimk 1024 Jul 22 19:24 pmc
[li11-226:pseudoinstall] 545 $ ll src/parrot/1.4.0-devel/
total 104
-rw-r--r-- 1 jimk jimk 13651 Jul 22 19:24 call_list.txt
drwxr-xr-x 2 jimk jimk  1024 Jul 22 19:24 dynpmc
drwxr-xr-x 2 jimk jimk  1024 Jul 22 19:24 ops
drwxr-xr-x 2 jimk jimk  3072 Jul 22 19:24 pmc
-rw-r--r-- 1 jimk jimk 75162 Jul 22 19:24 vtable.dump
-rw-r--r-- 1 jimk jimk  9195 Jul 22 19:24 vtable.tbl

I'm applying your patch now in r40221. If you (or allison or other readers) feel that additional clarification about the subdirectories is warranted, please submit an additional patch.

Thank you very much.
kid51

  Changed 5 years ago by jkeenan

  • status changed from new to assigned

  Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No complaints; closing ticket.

Thank you very much.
kid51

Note: See TracTickets for help on using tickets.