Ticket #794 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

split opcode should respect HLL mappings

Reported by: coke Owned by: NotFound
Priority: normal Milestone:
Component: core Version: trunk
Severity: medium Keywords:
Cc: Language: tcl
Patch status: applied Platform:

Description

Split calls Parrot_str_split, which unconditionally generates a ResizableStringArray - it should instead use Parrot_get_ctx_HLL_type to allow languages to override the type.

Attachments

TT_794.patch Download (1.5 KB) - added by NotFound 5 years ago.
Fix and test for HLL mapped split

Change History

Changed 5 years ago by coke

  • lang set to tcl

Changed 5 years ago by NotFound

Fix and test for HLL mapped split

Changed 5 years ago by NotFound

Attached a patch that does it and pass all parrot tests, adding a new one specific for this. Don't know if it risks to break some HLL, and then needs a deprecation cycle.

Changed 5 years ago by coke

I would vote that this is fixing a bug; If anyone disagrees (and thinks this should wait until after 1.4), speak up or I'll apply in a few days.

Changed 5 years ago by NotFound

  • owner set to NotFound
  • status changed from new to assigned
  • component changed from none to core
  • patch set to applied

Applied in r39854, if someone objects we can revert the change in the code and TODO the test. Leaving the ticket open for a few days.

Changed 5 years ago by allison

Looks great, thanks!

Changed 5 years ago by NotFound

  • status changed from assigned to closed
  • resolution set to fixed

No objections heard, no problems found, closing ticket.

Note: See TracTickets for help on using tickets.