Ticket #815 (closed patch: done)

Opened 5 years ago

Last modified 5 years ago

Add a step for Configure: auto::thread

Reported by: fperrad Owned by: fperrad
Priority: normal Milestone:
Component: configure Version: 1.3.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: all

Description

Currently PARROT_HAS_THREADS is computed in thread.h and is only accessible from C language.

This patch puts this logic in the step auto::thread, the key HAS_THREADS is added to Config.

Other benefit, an option --without-threads is now available.

Attachments

step-thread.patch Download (13.7 KB) - added by fperrad 5 years ago.
step-thread-v2.patch Download (13.9 KB) - added by fperrad 5 years ago.
fix --without-threads on linux

Change History

Changed 5 years ago by fperrad

  Changed 5 years ago by fperrad

  • status changed from new to assigned
  • owner set to fperrad

in reply to: ↑ description   Changed 5 years ago by jkeenan

  • summary changed from Add a step for Configure to Add a step for Configure: auto::thread

Replying to fperrad:

François: I commend you on your very thorough preparation of this patch. I appreciate the time and effort you take to get the tests right.

It  passed all tests on Darwin/PPC.

It  passed all tests on Linux/i386.

The extent to which the tests cover the code can be seen  here.

Two small points, then two larger questions:

1. t/steps/auto_thread-01.t Line 20: s/crypto/threads/

2. We will need to update MANIFEST before applying: perl tools/dev/mk_manifest_and_skip.pl

Larger questions:

3. Is there any way this patch could be done as part of an already existing configuration step?

Personally, I like it the way it is and I wouldn't want to muddy up some other step just to save a few processes. But I can bet that other contributors will raise that question, so I'm anticipating them.

4. While I'm satisfied with this addition, I'm no expert in threads. Does anyone else care to comment?

Thank you very much.

kid51

Changed 5 years ago by fperrad

fix --without-threads on linux

  Changed 5 years ago by jkeenan

I re-tested with step-thread-v2.patch.

make test passed on Darwin/PPC.

make fulltest passed on Linux/i386.

Okay by me to apply to trunk.

kid51

  Changed 5 years ago by fperrad

  • status changed from assigned to closed
  • resolution set to done
  • patch changed from new to applied

Applied in r39976

Note: See TracTickets for help on using tickets.