Ticket #824 (closed patch: fixed)

Opened 13 years ago

Last modified 13 years ago

[CAGE] refactor MSVC SAL with Configure

Reported by: fperrad Owned by: fperrad
Priority: normal Milestone:
Component: configure Version: 1.3.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: win32

Description

rename PARROT_HAS_SAL to PARROT_HAS_MSVC_SAL, and put the logic in Configure step auto::msvc.

Need test with MSVC.

PARROT_HAS_MSVC_SAL will be defined in has_header.h

Attachments

config-msvc-sal.patch Download (2.0 KB) - added by fperrad 13 years ago.

Change History

Changed 13 years ago by fperrad

Changed 13 years ago by rblasch

Looks good. Tested with VC 9.0.

Changed 13 years ago by fperrad

  • status changed from new to closed
  • resolution set to done
  • patch changed from new to applied

Applied in r39996

Changed 13 years ago by NotFound

  • status changed from closed to reopened
  • resolution done deleted

After r39996 I'm getting this warning a lot of times:

./include/parrot/compiler.h:134:5: warning: "PARROT_HAS_SAL" is not defined

Changed 13 years ago by rblasch

  • status changed from reopened to closed
  • resolution set to fixed

Right, should be #ifdef instead of #if. Sorry I missed this. Many thanks to fperrad for fixing this in r39998.

Changed 13 years ago by fperrad

  • cc rblasch removed
Note: See TracTickets for help on using tickets.