[patch]remove unused code, change function to macro, redefined UNUSED macro

[jimmy]

UNUSED macro now support multi-args, and some function changed to macro to make it does not compiled to binary code. and remove some unused codes, though there were still really unused code in src/ with USUSED macro.

[jimmy]

sorry,i should say 'with UNUSED macro. '

[whiteknight]

Variadic macros like you're using for UNUSED here aren't part of the C89 standard, and weren't added by most compilers until C99. So, we can't use them in Parrot (even if it would make some things more convenient. I'll take a look through the rest of this patch later to see if any other parts of it can be applied.

[jimmy]

In my mind, STM_TRACE(x...) is used here, UNUSED(a...) should be also right.

[jimmy]

and using STM_TRACE(x...) here is wrong?

[whiteknight]

That's very interesting. I don't think that STM_TRACE should be able to use a variadic macro since we are targetting C89. Maybe that's something that needs to be changed.

Any opinions on this?

[whiteknight]

I added a short XXX note to src/stm/backend.c about how the definition of STM_TRACE is not C89-compliant and needs to be rewritten. See r34287.

[jimmy]

whiteknight++

[jimmy]

but, it not r34387, it should be r34278

[jimmy]

ah, still wrong. I mean it is not r34287, should be r34278

[whiteknight]

I'm closing this ticket now. I've heard tell that STM is being ripped out eventually, so there might not be a need for me to update this STM_TRACE macro to use a better syntax.