Ticket #830 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] Configure.pl disable-rpath option

Reported by: gerd Owned by: allison
Priority: normal Milestone:
Component: install Version: 1.3.0
Severity: medium Keywords: rpath
Cc: doughera Language:
Patch status: applied Platform: all

Description

The disable-rpath option works fine in the file config/inter/libparrot.pm.

But rpath is added in config/init/defaults.pm from the Perl 5 configuration. This patch filter it out if disable-rpath is set.

Attachments

defaults.pm.patch Download (1.0 KB) - added by gerd 5 years ago.
generated with "diff -u config/init/defaults.pm config/init/defaults.pm.new

Change History

Changed 5 years ago by gerd

generated with "diff -u config/init/defaults.pm config/init/defaults.pm.new

in reply to: ↑ description   Changed 5 years ago by jkeenan

  • cc doughera added
  • platform set to all
  • keywords rpath added

Replying to gerd:

The disable-rpath option works fine in the file config/inter/libparrot.pm. But rpath is added in config/init/defaults.pm from the Perl 5 configuration. This patch will filter it out if disable-rpath is set.

Gerd,

Thanks for your patch. All I know about rpath I got just now from reading the  Wikipedia article. So, I'm not the best person to evaluate your patch. (Am cc-ing Andy D for that :-) )

But do I correctly understand your point? In other words, if we're going to use the --disable-rpath option, we should very early on make sure we prevent it from getting into the link_dynamic attribute in the Parrot::Configure object at all?

Also, you will have to add --disable-rpath to the list of valid options in (IIRC) lib/Parrot/Configure/Options/Conf/Shared.pm, add it to print_help() in lib/Parrot/Configure/Options/Conf.pm and write some brief documentation of it in Configure.pl.

Thank you very much.

kid51

  Changed 5 years ago by allison

  • patch changed from new to applied

We have a --disable-rpath option, added in r37823 for packagers. Most versions of Perl don't add -rpath to the ccdlflags configuration variable. Where they do, we don't need it anyway since that -rpath is relevant to dynamically linking to Perl 5 (which we never do). We really don't want it when the user has specifically requested disable-rpath.

Applied in r40098.

  Changed 5 years ago by gerd

It works on Fedora and SuSE (Michael Schroeder should agree). The ticket can be closed.

Thanks

  Changed 5 years ago by doughera

Agreed. Actually, I'd go farther -- I can't think of any situation in which parrot ought to keep perl5's rpath setting. I think it could be safely deleted completely independently of any disable-rpath option.

  Changed 5 years ago by jkeenan

  • owner set to allison

  Changed 5 years ago by jkeenan

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.