Ticket #836 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[DEPRECATED] ops file preamble format

Reported by: cotto Owned by:
Priority: minor Milestone:
Component: core Version:
Severity: medium Keywords: ops2c
Cc: Language:
Patch status: Platform:

Description

The ops file format has some cruft in the form of the "VERSION = PARROT_VERSION;" line and is hard to parse when several ops files are concatenated together. I propose the following two changes to the format (which the attached patch implements):

Remove the VERSION = PARROT_VERSION; line. It seems to be a historical leftover that's no longer needed.

Make any C code or preprocessor directives which need to be included with the final C code explicit by surrounding them with OPS_PREAMBLE_START and OPS_PREAMBLE_END. This change will also mean less work for the new PCT-based ops compiler.

If there are no complaints, I'll apply this after the 1.4 release.

Attachments

ops_format_update.patch Download (6.1 KB) - added by cotto 5 years ago.

Change History

Changed 5 years ago by cotto

Changed 5 years ago by jkeenan

  • component changed from none to core

Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

applied with some additional changes in r40198

Note: See TracTickets for help on using tickets.