Ticket #84 (closed patch: fixed)

Opened 6 years ago

Last modified 6 years ago

[patch][RFC] gc_ims.c

Reported by: jimmy Owned by: whiteknight
Priority: normal Milestone: 0.9.1
Component: GC Version:
Severity: medium Keywords: ims
Cc: Language:
Patch status: new Platform: all

Description (last modified by chromatic) (diff)

there was a redundant if-condition in src/gc/gc_ims.c, and this patch removed it. It's in trunk now.

Attachments

patch.patch Download (0.6 KB) - added by jimmy 6 years ago.

Change History

Changed 6 years ago by whiteknight

  • status changed from new to assigned
  • component changed from none to GC
  • owner set to whiteknight
  • summary changed from [patch]change two conditions to one to [patch][RFC] gc_ims.c
  • platform set to all
  • milestone set to 0.9.1
  • keywords ims added
  • patch set to new

gc_ims.c isn't currently used in Parrot, and I'm pretty certain that it's not even functional at this point.

Question: Are we intending to actually pursue, implement, and improve this collector? If we don't intend to pursue it, or if there are no people actively hacking on it, it might be better to just remove gc_ims.c from the repository entirely.

I certainly don't see any point in patching this file if we're not using it, and removing unused and unneeded code from the repo is always good to me.

--Andrew Whitworth

Changed 6 years ago by chromatic

  • status changed from assigned to closed
  • resolution set to fixed
  • description modified (diff)

I applied something very much like this patch on the GC refactoring branch around r35194.

Changed 6 years ago by jimmy

Changed 6 years ago by jimmy

this hadn't be patched yet. now that the GC refactoring had started, I uploaded a new patch for the trunk now.

Changed 6 years ago by cotto

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 6 years ago by whiteknight

  • status changed from reopened to closed
  • resolution set to fixed

I applied the new patch in r 35731. Closing this ticket.

Note: See TracTickets for help on using tickets.