[patch]various consting, memory leak fixes and so on.

[jimmy]

1. fixed some places that should be used with Parrot_str_free_cstring.
2. various consting.
3. other fixes.

[jimmy]

please use the cage.2.patch, the cage.patch is not right.

[dukeleto]

Howdy,

I applied this patch to r41123, only one hunk failed, but I am getting a failing test:

$ prove -v t/op/spawnw.t

ok 1 - exit code: 0
ok 2 - exit code: 123
ok 3 - exit code: 3
ok 4 - exit code: 0
ok 5 - exit code: 123
ok 6 - exit code: 3
not ok 7 - grow argv buffer

#   Failed test 'grow argv buffer'
#   at t/op/spawnw.t line 141.
#          got: 'return code: 255
# '
#     expected: 'return code: 10
# '
# Looks like you failed 1 test of 7.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 

Test Summary Report
-------------------
t/op/spawnw.t (Wstat: 256 Tests: 7 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1

If you can attach some smaller patches, that fix each file, it will be easier to figure out what is causing this test failure. I did apply one part of the patch that fixes some documentation in src/pmc/env.pmc .

[jimmy]

new patch

[jimmy]

Hello, I added the newest patch, please try again.

[jkeenan]

Replying to jkeenan:

jimmy and I discussed this on IRC. Some files touched by this patch have changed since the patches were originally created. So I'm recommending jimmy touch these up and submit in two separate patches -- one for the 3 Win32-specific files and one for the other 7.

kid51

[jkeenan]

Replying to jkeenan:

Replying to jkeenan: jimmy and I discussed this on IRC. Some files touched by this patch have changed since the patches were originally created. So I'm recommending jimmy touch these up and submit in two separate patches -- one for the 3 Win32-specific files and one for the other 7.

1. Should src/pmc/string.pmc be in both patches?
2. I'll test the non-Win32 patch again after tomorrow's release.
3. I'm going to cc some our Win32 developers to ask them to test that patch after tomorrow's release.

Thank you very much.
kid51