Ticket #92 (closed RFC: wontfix)

Opened 6 years ago

Last modified 4 years ago

Should all header files under src/ be moved to include/ dir?

Reported by: jimmy Owned by:
Priority: trivial Milestone:
Component: install Version:
Severity: low Keywords:
Cc: Language:
Patch status: Platform:

Description

There were many header files under src/, like bignum.h, src/stm/stm_internal.h, src/stm/stm_waitlist.h, etc. They should be moved to include/parrot/, like include/parrot/bignum.h, include/parrot/stm/internal.h,include/parrot/stm/waitlish.h, etc.

Change History

  Changed 6 years ago by jimmy

sorry, waitlish.h changes to waitlist.h

  Changed 6 years ago by whiteknight

Some of the .h files in the src/ directory are built from platform-specific files in subdirectories and are only used internally. Also header files which are intended to only be included once or twice and are not supposed to be used more then that probably shouldn't be together with the rest of the "General purpose" header files.

I don't really have an opinion on this, so long as people have the tuits to accomplish it cleanly. I know that some of the header files in src/jit/* contain executable code and so really shouldn't be moved anywhere until that is resolved.

  Changed 6 years ago by coke

- Show quoted text - please check PDD07. it makes clear our header location policy, if i'm not mistaken. ~jerry - Show quoted text -

(Adding jerry's comment to the ticketing system: reminder, replying to tickets doesn't save your comment in trac.)

  Changed 6 years ago by coke

  • priority changed from normal to trivial
  • severity changed from medium to low

follow-up: ↓ 7   Changed 6 years ago by whiteknight

I just checked through PDD07 again, and I can't find any specific mention of what directories header files should or should not be in. Am I missing something?

  Changed 5 years ago by jkeenan

  • component changed from none to install

in reply to: ↑ 5   Changed 5 years ago by jkeenan

Replying to whiteknight:

I just checked through PDD07 again, and I can't find any specific mention of what directories header files should or should not be in. Am I missing something?

I don't think you are. I just scanned that file and could not locate any discussion of file locations either.

kid51

  Changed 4 years ago by jimmy

  • status changed from new to closed
  • resolution set to wontfix

It's unreasonable, I recall it.

Note: See TracTickets for help on using tickets.