Ticket #93 (closed patch: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH]removed unnecessary code

Reported by: jimmy Owned by:
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

because these codes will always be run at the end

    memcpy(s->strstart, buffer_next, len);
    s->bufused = s->strlen = len;
    return len

these codes is unnecessary.

Attachments

patch.patch Download (1.4 KB) - added by jimmy 6 years ago.

Change History

Changed 6 years ago by jimmy

Changed 6 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Thanks for noticing. The editor patch was applied in r34373 and the io patch was applied in r34374. As expected, this didn't cause any new test failures. In the future I recommend keeping separate things separate (i.e. submit only the patch for buffer.c and bug someone on #parrot about the editor fix), but that's a very minor issue.

Changed 6 years ago by jimmy

thanks cotto, editor patch is so minor, i feel embarrassed to create it.

Note: See TracTickets for help on using tickets.