Ticket #951 (closed patch: done)

Opened 5 years ago

Last modified 4 years ago

correct some minor bugs in t/pmc/threads.t

Reported by: kyle_l5l Owned by:
Priority: normal Milestone:
Component: testing Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: new Platform:

Description

Here's a little patch that corrects some minor bugs in t/pmc/threads.t, allowing tests 10 and 14 to pass. Also, test 14 now uses Integers instead of PerlInts - I think this satisfies RT#41373 ?

Attachments

threads.t.patch Download (2.0 KB) - added by kyle_l5l 5 years ago.

Change History

Changed 5 years ago by kyle_l5l

Changed 5 years ago by dukeleto

One of the tests still fails for me with this patch on OS X 10.5.x .

Changed 5 years ago by jkeenan

  • priority changed from trivial to normal
  • component changed from none to testing
  • severity changed from low to medium

Changed 4 years ago by jkeenan

  • status changed from new to closed
  • resolution set to done

The patch provided here is no longer directly applicable.

In the case of vtable overrides aren't properly cloned, t/pmc/threads.t has been altered at the critical point since the patch was submitted. The test is still TODO-ed but that is being tracked in TT #1248.

The other case addressed in the patch is similar: While unresolved, it is being tracked in TT #1250.

I'm going to close this ticket and ask kyle_151 and dukeleto to look at those two TTs.

Thank you very much.

kid51

Note: See TracTickets for help on using tickets.