Ticket #974 (new todo)

Opened 5 years ago

Last modified 4 years ago

Mark publicly exposed functions in src/call/context.c with PARROT_EXPORT tag

Reported by: bacek Owned by: whiteknight
Priority: minor Milestone:
Component: core Version: master
Severity: low Keywords: context, api
Cc: whiteknight Language:
Patch status: Platform: all

Description

Hello.

There is some functions in src/call/context.c which marked as PARROT_EXPORT but shouldn't be exposed as PARROT_API. For example Parrot_pcc_get_context_struct must not be in public API, etc. Functions exposed as public should be marked as PUBLIC_API to avoid and confusion between internals and exposed API for 3rd party developers.

-- Bace

Change History

  Changed 5 years ago by jkeenan

  • type changed from cage to todo
  • summary changed from [todo] Mark publicly exposed functions in src/call/context.c with PARROT_API tag. to Mark publicly exposed functions in src/call/context.c with PARROT_API tag

  Changed 5 years ago by jkeenan

  • component changed from none to core

in reply to: ↑ description   Changed 4 years ago by jkeenan

  • cc whiteknight added

Replying to bacek:

whiteknight:

Would this fall under the rubric of the API team's efforts?

kid51

  Changed 4 years ago by whiteknight

  • severity changed from medium to low
  • summary changed from Mark publicly exposed functions in src/call/context.c with PARROT_API tag to Mark publicly exposed functions in src/call/context.c with PARROT_EXPORT tag
  • priority changed from normal to minor
  • platform set to all
  • version changed from trunk to master
  • keywords context, api added
  • owner set to whiteknight

The tag PARROT_API is currently only for functions in the embedding API. i've updated the ticket title to reflect that.

Some of the functions in src/call/context.c probably should not be marked PARROT_EXPORT or PARROT_API, since they are internal only. I can imagine some of them might be useful for the extending API, but certainly not for the embedding API. We need to go over the list of functions in that file and make sure they are only as visible as is absolutely necessary.

  Changed 4 years ago by jkeenan

Can we get an update on the status of the issues discussed in this ticket?

Thank you very much.

kid51

Note: See TracTickets for help on using tickets.