Ticket #999 (closed patch: fixed)

Opened 4 years ago

Last modified 4 years ago

convert some base_type to VTABLE lookups.

Reported by: coke Owned by:
Priority: normal Milestone:
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

Attached patch changes Scalar's assign_pmc to avoid base_type and prefer VTABLE_type, as per

 http://lists.parrot.org/pipermail/parrot-dev/2008-October/000071.html

With this patch, make test passes, no change. partcl changes from complaining about "object must be created by class" to "set_pmc() not implemented in class 'TclList'" which is a slight improvement.

Posted as patch for review. If it looks sane, please apply.

Attachments

types.diff Download (1.2 KB) - added by coke 4 years ago.

Change History

Changed 4 years ago by coke

Changed 4 years ago by bacek

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Reviewed and applied (with some more cleanups) at r41204.

Note: See TracTickets for help on using tickets.