| 2 | |
| 3 | ---- |
| 4 | |
| 5 | nwellnhof: I just fixed a bunch of warnings. This is what I get with Debian unstable, i386, GCC 4.4.5, non-optimized |
| 6 | |
| 7 | The following are caused by -Wbad-function-cast and can be avoided by removing the cast. I'm not sure if this is safe for g++. |
| 8 | |
| 9 | {{{ |
| 10 | src/hash.c: In function ‘Parrot_hash_thaw’: |
| 11 | src/hash.c:681: warning: cast from function call of type ‘INTVAL’ to non-matching type ‘enum <anonymous>’ |
| 12 | src/hash.c:682: warning: cast from function call of type ‘INTVAL’ to non-matching type ‘enum <anonymous>’ |
| 13 | src/nci/signatures.c: In function ‘Parrot_nci_sig_to_pcc’: |
| 14 | src/nci/signatures.c:184: warning: cast from function call of type ‘INTVAL’ to non-matching type ‘enum <anonymous>’ |
| 15 | }}} |
| 16 | |
| 17 | Calls to parrot_hash_put with const keys or values: |
| 18 | |
| 19 | {{{ |
| 20 | src/runcore/main.c: In function ‘parrot_hash_oplib’: |
| 21 | src/runcore/main.c:345: warning: cast discards qualifiers from pointer target type |
| 22 | src/runcore/main.c:348: warning: cast discards qualifiers from pointer target type |
| 23 | src/runcore/main.c:349: warning: cast discards qualifiers from pointer target type |
| 24 | }}} |
| 25 | |
| 26 | These could be fixed with a temporary variable: |
| 27 | |
| 28 | {{{ |
| 29 | ./src/pmc/imageiothaw.pmc: In function ‘Parrot_ImageIOThaw_shift_float’: |
| 30 | ./src/pmc/imageiothaw.pmc:240: warning: cast discards qualifiers from pointer target type |
| 31 | ./src/pmc/imageiothaw.pmc: In function ‘Parrot_ImageIOThaw_shift_integer’: |
| 32 | ./src/pmc/imageiothaw.pmc:220: warning: cast discards qualifiers from pointer target type |
| 33 | ./src/pmc/imageiothaw.pmc: In function ‘Parrot_ImageIOThaw_shift_string’: |
| 34 | ./src/pmc/imageiothaw.pmc:276: warning: cast discards qualifiers from pointer target type |
| 35 | }}} |