Changes between Version 6 and Version 7 of ItsABughunt

Show
Ignore:
Timestamp:
02/05/10 18:54:10 (4 years ago)
Author:
darbelo
Comment:

The main complaints against this code have been adressed, let's remove it now and add it back when new complaints arise.

Legend:

Unmodified
Added
Removed
Modified
  • ItsABughunt

    v6 v7  
    1616(Perhaps now is a good time to re-examine the thought of using an external hash library rather than re-inventing our own. --coke) 
    1717 
    18  * freeze/thaw 
    19    * The code in src/pmc_freeze.c pokes deep into the guts of the STRING structure, without using any kind of API, hindering any kind of refactoring or cleanup of STRING internals. 
    20    * It also relies on implementation details of the io subsystem, such that altering seemingly unrelated io functions can cause segfaults or misbehavior of the freeze/thaw code. This is often related to the string poking. 
    21    * The code and comments in this subsystem give the impression of being a exploratory prototype or following an incomplete specification. For example, the main data structure in the freeze/thaw process (IMAGE_IO) claims to be a "stand-in for some kind of serializer PMC which will eventually be written". 
    22    * There are hints in the documentation that the current implementation dates as far back as 2003, with comments that some parts of it "might go away sometime". 
    23  
    2418 * CLI argument parsing 
    2519   * The current code is closely tied to imcc and will inhibit the eventual migration to pirc.