Changes between Version 47 and Version 48 of ModParrotArchitecture

Timestamp:

12/11/08 22:26:44 (5 years ago)

Author:

jhorwitz

Comment:

--

ModParrotArchitecture

@@ -281 +281 @@
 {{{
 struct modparrot_cleanup_info {
-    int module_index;    /* the HLL module that registered us */
+    module *module;      /* the HLL module that registered us */
     Parrot_PMC callback; /* callback subroutine */
     Parrot_PMC hll_data; /* a PMC to pass to the callback */
@@ -290 +290 @@
 }}}
 
-{{{module_index}}} lets us know which module registered us.  {{{callback}}} is the Sub PMC that should be invoked, and {{{hll_data}}} is a PMC that should be passed to the callback.  {{{modparrot_meta_request_cleanup}}} is a generic callback function that uses this data to set the module index and call the subroutine.
+We use the actual Apache {{{module}}} struct instead of the usual {{{module_index}}} idiom here, as cleanups are not real Apache hooks and therefore don't have a module array to index in the configuration.  More importantly, the timing of cleanup registration and execution is indeterminate, since cleanups can be registered during the request, and pools can be destroyed at various points during a connection.
+
+{{{modparrot_meta_request_cleanup}}} is a generic callback function that uses this data to set the module index and call the subroutine.
 
 == Multiprocessing Module Support ==