|Version 3 (modified by cotto, 4 years ago)|
Miscellanea and General Cleanup
- Don't differentiate between "initial" packfiles and others. We should initialize the interpreter properly, and load all packfiles in through a common interface
- Break up src/packfile/api.c into a series of smaller files, by separating out functions that work on similar things
- Allocate Packfile structures through the GC fixed size allocator, not mem_sys_alloc and friends
- Don't use PARROT_EXPORT for anything (with *very few* exceptions) in src/packfile/*. This subsystem should be private and should not be used by external utilities
- Rename subsystem API functions to Parrot_pf_*
- Don't differentiate between PBC_LOAD and PBC_INIT functions in a packfile
The PackFile structure should keep track of the current PBC_MAIN function, and not rely on storing a reference to it in CURRENT_CONTEXT(interp). This way we can query the main function of any packfile at any time
- Packfile functions should not write to Parrot_io_printf or Parrot_io_eprintf directly. Functions should throw exceptions on error, or print errors to an error buffer so an embedding application and choose where to send it.
- break compile_or_load file into two functions, one that loads a .pbc file, and one that compiles a PIR function. Deprecate the later.
- Parrot_load_language is an HLL function. it belongs in src/hll.c or similar, not in src/packfile/api.c
Segment Dump Operations
There are utilities for dumping the contents of a Packfile. These need help:
- All dump-related functions should move to src/packfile/packdump.c
- These functions should not output to stdout. Either add to a STRING, a StringBuilder, or some kind of new PackfileDumpVisitor
- These functions should not be part of struct PackFile_funcs
- Actually, do these functions belong in src/packfile/* at all, or in frontends/pbc_dump/*? Or, do they belong as PMC methods?